Validate encrypted tile payload bounds; add regression test and update docs#13
Open
Validate encrypted tile payload bounds; add regression test and update docs#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
decrypt_tile_if_neededto validate header metadata offsets and encrypted payload length and raiseDownloadErroron malformed data.test_download_tiles_rejects_malformed_encrypted_payloadintests/test_tile_cache.pyto cover malformed encrypted tile handling during tile download.docs/project-status.mdto referencesrc/artx/...instead of stalesrc/googleart_download/...and changecompatibility-shelltocompatibility-shim.Testing
uv run pytest -q tests/test_tile_cache.py tests/test_transport.pyand received32 passed.uv run ruff check src/artx/download/tiles.py tests/test_tile_cache.py docs/project-status.mdand all checks passed.Codex Task